Skip to content

[Kernel][Bugfix] Re-fuse triton moe weight application #16071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[Kernel][Bugfix] Re-fuse triton moe weight application #16071

merged 1 commit into from
Apr 4, 2025

Conversation

@bnellnm
Copy link
Collaborator

@bnellnm bnellnm commented Apr 4, 2025 •
edited by github-actions bot
Loading

The unfused version of weight application in the triton fused moe kernels got landed accidentally. This PR reverts it back to the original state.

cc @tlrmchlsmth , @LucasWilkinson , @WoosukKwon

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@bnellnm bnellnm changed the title [Kernels][Minor] Re-fuse triton moe weight application [Kernel][Minor] Re-fuse triton moe weight application Apr 4, 2025
LucasWilkinson
LucasWilkinson approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 4, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) April 4, 2025 20:57
@tlrmchlsmth tlrmchlsmth changed the title [Kernel][Minor] Re-fuse triton moe weight application [Kernel][Bugfix] Re-fuse triton moe weight application Apr 4, 2025
@mgoin mgoin added bug Something isn't working moe labels Apr 4, 2025
@tlrmchlsmth tlrmchlsmth merged commit d6fc629 into vllm-project:main Apr 4, 2025
63 checks passed
@bnellnm bnellnm deleted the re-fuse-moe-weights branch April 5, 2025 00:22
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@bnellnm @Alex4210987
[Kernel][Minor] Re-fuse triton moe weight application (vllm-project#1…
62e09b8 
…6071)

Signed-off-by: Bill Nell <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@bnellnm @lulmer
[Kernel][Minor] Re-fuse triton moe weight application (vllm-project#1…
a1fbed6 
…6071)

Signed-off-by: Bill Nell <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@bnellnm @lk-chen
[Kernel][Minor] Re-fuse triton moe weight application (vllm-project#1…
0ef3153 
…6071)

Signed-off-by: Bill Nell <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@bnellnm @shreyankg
[Kernel][Minor] Re-fuse triton moe weight application (vllm-project#1…
eb59756 
…6071)

Signed-off-by: Bill Nell <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@bnellnm
[Kernel][Minor] Re-fuse triton moe weight application (vllm-project#1…
ff9a6d7 
…6071)

Signed-off-by: Bill Nell <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@mgoin mgoin mgoin approved these changes

@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes

Assignees

No one assigned

Labels

bug Something isn't working moe ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bnellnm @tlrmchlsmth @mgoin @LucasWilkinson