-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[BugFix][V1] Quick fix for min_tokens with multiple EOS #15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reported by @andylolu2 in slack. This can affect min_tokens function for models that define more than one EOS token in their config. We need to revisit how SamplingParams.__post_init__ is used generally, as well as test coverage for this specific case. This is a quick fix in the meantime for a point release planned for today. Signed-off-by: Nick Hill <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…#15407) Signed-off-by: Nick Hill <[email protected]>
…#15407) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Wes Medford <[email protected]>
…#15407) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…#15407) Signed-off-by: Nick Hill <[email protected]>
…#15407) Signed-off-by: Nick Hill <[email protected]>
…#15407) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Reported by @andylolu2 in slack. This can affect
min_tokensfunctionality for models that define more than one EOS token in their config.We need to revisit how
SamplingParams.__post_init__is used generally, as well as test coverage for this specific case. This is a quick fix in the meantime for a point release planned for today.