Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

Remove warnings related to LoRA quantization, and also slightly improve the comments in PunicaWrapperGPU

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from DarkLight1337 March 24, 2025 10:57
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from mgoin March 24, 2025 11:21
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 24, 2025 19:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2025
@vllm-bot vllm-bot merged commit 6db9457 into vllm-project:main Mar 25, 2025
45 of 47 checks passed
@jeejeelee jeejeelee deleted the remove-lora-log branch March 25, 2025 03:53
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-merge ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants