Skip to content

[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2025
Merged

[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout #15301

merged 2 commits into from
Mar 22, 2025

Conversation

@ruisearch42
Copy link
Collaborator

@ruisearch42 ruisearch42 commented Mar 21, 2025 •
edited by github-actions bot
Loading

Execution in DeepSeek may take a long time, this PR sets a larger default (300s, rather than 10s) for RAY_CGRAPH_get_timeout, but still allows user to override it.

FIX #15199

@github-actions
Copy link

github-actions bot commented Mar 21, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

comaniac
comaniac reviewed Mar 21, 2025
View reviewed changes
@ruisearch42
up
1bb92c6 
Signed-off-by: Rui Qiao <[email protected]>
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 21, 2025
@comaniac comaniac enabled auto-merge (squash) March 21, 2025 20:33
@WoosukKwon WoosukKwon disabled auto-merge March 22, 2025 05:25
@WoosukKwon WoosukKwon merged commit 4c69e22 into vllm-project:main Mar 22, 2025
40 of 43 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@ruisearch42 @erictang000
[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout (vllm-p…
af6b7cb 
…roject#15301)

Signed-off-by: Rui Qiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ruisearch42 @lulmer
[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout (vllm-p…
bdc3102 
…roject#15301)

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@yangli5t yangli5t mentioned this pull request Apr 16, 2025
Merged
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@ruisearch42 @lk-chen
[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout (vllm-p…
f4a85d8 
…roject#15301)

Signed-off-by: Rui Qiao <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@ruisearch42 @shreyankg
[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout (vllm-p…
006d39a 
…roject#15301)

Signed-off-by: Rui Qiao <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ruisearch42
[Misc] Increase RayDistributedExecutor RAY_CGRAPH_get_timeout (vllm-p…
578ed67 
…roject#15301)

Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniac comaniac comaniac approved these changes

Assignees

@comaniac comaniac

@youkaichao youkaichao

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't deserialize object reported by ray, H800*16 DeepSeek R1

4 participants

@ruisearch42 @comaniac @youkaichao @WoosukKwon