-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[TPU][V1] MHA Pallas backend #15288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU][V1] MHA Pallas backend #15288
Conversation
Signed-off-by: NickLucche <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work! FYI @Isotr0py
| from vllm.attention.selector import _cached_get_attn_backend | ||
| from vllm.platforms import current_platform | ||
|
|
||
| if not envs.VLLM_USE_V1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also check for the default behavior env bar as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember I discussed it with @robertgshaw2-redhat 🤔
Maybe I can check if the env was set rather than its value?
Isotr0py
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ViT part LGTM too!
|
FYI CI errors look unrelated, it's the same thing we have on main https://buildkite.com/vllm/ci/builds/16011#0195b8a1-d554-46b6-9929-798657dcabbf |
|
You can merge from main branch, the failing kennel tests have been fixed by #15282 |
|
Thanks! Didn't see the PR mb |
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]> Signed-off-by: Mu Huai <[email protected]>
The torch sdpa F.scaled_dot_product_attention impl is particularly inefficient on TPU.
It's both slow and also causes issues when XLA compiling as reported here #15051, which is a major obstacle in multimodal adoption on TPU.
This PR adds a Pallas branch to the vanilla MHA module used in most ViTs.
Some numbers:
Pre PR (TPUv6):
Post PR (TPUv6):
Throughput boost is significant, almost 4x in this instance.