-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Bugfix] Add int8 torch dtype for KVCache #15260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shen-shanshan <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we ever tested any thing with int8 KV cache?
Is adding an item to a map enough? I am wondering how int8 KV works here.
I think no quantization in main repo support int8 kv cache currently, but some OOT hardware like |
Yes, thanks for your explaination~ |
Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: shen-shanshan <[email protected]>
Signed-off-by: shen-shanshan <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Some attention backend requires
int8kvcache dtype (e.g., quantization). It is used in initialization of CacheConfig:But there are no
int8dtype inSTR_DTYPE_TO_TORCH_DTYPE:So, I think maybe it's better to add
int8into thisSTR_DTYPE_TO_TORCH_DTYPE.