-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[BugFix] Lazily import XgrammarBackend to avoid early cuda init #15171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Importing xgrammar appears to initialize the cuda context, which we don't want to do in the front-end process. It also means that the server can't be started with the (default) multiproc context mode of fork. I guess this is what LazyLoader is meant to help with, but it doesn't seem to be working as intended since vllm-project#14694 was merged. Signed-off-by: Nick Hill <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
russellb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks harmless, so I'm fine with it. I don't understand why it fixes anything though :(
|
Ah I found it's due to references to |
oh, weird ... I thought that was ignored unless running type checking. I wonder if using a Forward Reference (putting the type in quotes) would also work around the issue? I'm still fine just merging this PR for now, though. |
You can use |
…-project#15171) Signed-off-by: Nick Hill <[email protected]>
…-project#15171) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…-project#15171) Signed-off-by: Nick Hill <[email protected]>
…-project#15171) Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Importing xgrammar appears to initialize the cuda context, which we don't want to do in the front-end process. It also means that the server can't be started with the (default) multiproc context mode of fork.
I guess this is what LazyLoader is meant to help with, but it doesn't seem to be working as intended since #14694 was merged.