Skip to content

Conversation

@DarkLight1337
Copy link
Member

Since V1 is now used by default, we need to apply SupportsV0Only for Phi-4-multimodal so V0 is automatically selected when running the model.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 16, 2025
@DarkLight1337 DarkLight1337 added this to the v0.8.0 milestone Mar 16, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) March 16, 2025 14:54
@vllm-bot vllm-bot merged commit e53b135 into vllm-project:main Mar 16, 2025
27 of 36 checks passed
@DarkLight1337 DarkLight1337 deleted the phi4-mm-v0 branch March 16, 2025 16:06
DefTruth pushed a commit to DefTruth/vllm that referenced this pull request Mar 17, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants