-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Bugfix] Fix small typo in the example of Streaming delimiter #14793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Can you verify that streaming still works for your PR? In case it triggers a regression from #2756 |
|
Yes, streaming still can work Below is my test code and send message if no change \0 to \n, you'll get an |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing and testing!
…roject#14793) Signed-off-by: Richard Liu <[email protected]>
…roject#14793) Signed-off-by: Louis Ulmer <[email protected]>
…roject#14793) Signed-off-by: Mu Huai <[email protected]>
fix small typo in the example of Streaming delimiter
This is apiserver delimiter