Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Mar 13, 2025

The lora test for this model has issues:

  1. It requires downloading 2 models.
  2. It doesn't actually test by training a LoRA model.

Delete the lora test for this model to reduce CI testing pressure.

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee requested a review from DarkLight1337 March 13, 2025 06:28
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 13, 2025 06:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@DarkLight1337 DarkLight1337 merged commit bd44b81 into vllm-project:main Mar 13, 2025
31 of 34 checks passed
@jeejeelee jeejeelee deleted the remove-ultravox-lora branch March 13, 2025 08:13
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants