Skip to content

Re-enable the AMD Entrypoints Test #14711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 14, 2025
Merged

Re-enable the AMD Entrypoints Test #14711

merged 14 commits into from
Mar 14, 2025

Conversation

@Alexei-V-Ivanov-AMD
Copy link
Collaborator

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD commented Mar 12, 2025 •
edited by github-actions bot
Loading

Re-enable the AMD Entrypoints Test

Signed-off-by: Alexei V. Ivanov [email protected]

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 12, 2025
robertgshaw2-redhat
robertgshaw2-redhat reviewed Mar 13, 2025
View reviewed changes
.buildkite/test-pipeline.yaml Outdated
- pytest -v -s entrypoints/llm/test_guided_generate.py # it needs a clean process
- pytest -v -s entrypoints/openai --ignore=entrypoints/openai/test_oot_registration.py --ignore=entrypoints/openai/correctness/
- pytest -v -s entrypoints/test_chat_utils.py
- pytest -v -s entrypoints/openai --ignore=entrypoints/openai/test_oot_registration.py --ignore=entrypoints/openai/correctness/ --ignore=entrypoints/openai/test_vision.py
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add skipping logic to the tests themselves to skip only on ROCM

Copy link
Collaborator Author

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is experimental. This change is going to get reverted.

Copy link
Collaborator Author

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertgshaw2-redhat Please have a look at the PR now.
It fixes the "AMD Entrypoints Test". (https://buildkite.com/vllm/fastcheck/builds/16847#01959170-4ba5-4fc3-954c-a67be1163a31)

Thank you!

@Alexei-V-Ivanov-AMD
Fencing the failing Entrypoints tests.
d080ba9 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Restoring the tests with microsoft/Phi-3.5-vision-instruct
2e5d3c9 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Making linter happy.
5b2d0d3 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Keep linter happy (continued).
1a849e4 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Making linter happy (ancora una volta).
9d49cd3 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Correcting exclusion logic.
16aaf5b 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Correcting exclusion logic. (Fixed regexp).
1df0902 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Upsie.
8408c8b 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Restoring original requirements/test.* files
439ce30 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Making rocm-test specific dependencies.
96d7f12 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
ROCm-specific dependencies (continued)
e9aa53e 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Fixing rocm-test.txt list.
e798e6d 
Signed-off-by: Alexei V. Ivanov <[email protected]>
@Alexei-V-Ivanov-AMD
Excluding openai/test_models.py as it crashes on MI250.But it still p…
35ecd92 
…asses on MI300.

Signed-off-by: Alexei V. Ivanov <[email protected]>
@khluu khluu enabled auto-merge (squash) March 14, 2025 19:06
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@simon-mo simon-mo disabled auto-merge March 14, 2025 19:18
@simon-mo simon-mo merged commit 270a5da into vllm-project:main Mar 14, 2025
37 of 40 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Alexei-V-Ivanov-AMD @lulmer
Re-enable the AMD Entrypoints Test (vllm-project#14711)
465136c 
Signed-off-by: Alexei V. Ivanov <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Alexei-V-Ivanov-AMD @shreyankg
Re-enable the AMD Entrypoints Test (vllm-project#14711)
c0873b5 
Signed-off-by: Alexei V. Ivanov <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Alexei-V-Ivanov-AMD
Re-enable the AMD Entrypoints Test (vllm-project#14711)
d5f2628 
Signed-off-by: Alexei V. Ivanov <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat left review comments

@khluu khluu khluu approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alexei-V-Ivanov-AMD @khluu @robertgshaw2-redhat @simon-mo