Skip to content

Correct capitalisation: Github -> GitHub #14561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Correct capitalisation: Github -> GitHub #14561

merged 1 commit into from
Mar 10, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Mar 10, 2025

Replaces #11915

@github-actions
Copy link

github-actions bot commented Mar 10, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Mar 10, 2025
@russellb russellb added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 10, 2025
@russellb russellb enabled auto-merge (squash) March 10, 2025 13:21
@russellb russellb merged commit 39be303 into vllm-project:main Mar 10, 2025
48 of 50 checks passed
@hmellor hmellor deleted the github-spelling branch March 26, 2025 11:13
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Correct capitalisation: Github -> GitHub (vllm-project#14561)
f4a291f 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Correct capitalisation: Github -> GitHub (vllm-project#14561)
35f6d32 
Signed-off-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmellor @russellb @jeejeelee @DarkLight1337