Skip to content

[core] Pass all driver env vars to ray workers unless excluded #14099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

[core] Pass all driver env vars to ray workers unless excluded #14099

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e83965
[core] Pass all driver env vars to ray workers unless excluded
ruisearch42 Mar 2, 2025
0c15938
up
ruisearch42 Mar 2, 2025
7be8f50
up
ruisearch42 Mar 3, 2025
6a91bd5
up
ruisearch42 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions vllm/executor/ray_distributed_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,21 @@ class RayWorkerMetaData:


class RayDistributedExecutor(DistributedExecutorBase):
"""Ray-based distributed executor"""

# These env vars are used at installation time, therefore are NOT copied
# from the driver to the workers
INSTALL_TIME_ENV_VARS = set([
"VLLM_TARGET_DEVICES", "MAX_JOBS", "NVCC_THREADS",
"VLLM_USE_PRECOMPILED", "CMAKE_BUILD_TYPE", "VERBOSE",
"VLLM_CONFIG_ROOT"
])

# These env vars are worker-specific, therefore are NOT copied
# from the driver to the workers
WORKER_SPECIFIC_ENV_VARS = set([
"VLLM_HOST_IP", "VLLM_HOST_PORT", "LOCAL_RANK", "CUDA_VISIBLE_DEVICES"
])

uses_ray: bool = True

Expand Down Expand Up @@ -311,9 +326,9 @@ def sort_by_driver_then_worker_ip(item: RayWorkerMetaData):

# Environment variables to copy from driver to workers
env_vars_to_copy = [
"VLLM_ATTENTION_BACKEND", "TPU_CHIPS_PER_HOST_BOUNDS",
"TPU_HOST_BOUNDS", "VLLM_USE_V1", "VLLM_TRACE_FUNCTION",
"VLLM_TORCH_PROFILER_DIR", "VLLM_TEST_ENABLE_EP"
v for v in envs.environment_variables
if v not in self.INSTALL_TIME_ENV_VARS
and v not in self.WORKER_SPECIFIC_ENV_VARS
]

# Copy existing env vars to each worker's args
Expand Down