Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Feb 27, 2025

FIX #13817 (link existing issues this PR will resolve)

  • Qwen2.5-VL-3B will overflow with float16 in its ViT encoder, we need to cast the overflow value manually.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 27, 2025 15:06
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 DarkLight1337 merged commit 7864875 into vllm-project:main Feb 27, 2025
35 checks passed
@Isotr0py Isotr0py deleted the fix-qwen2_5vl-overflow branch February 28, 2025 02:23
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Qwen2.5-VL-3B Returning Series of !!! for Specific Image when "dtype" Set to "float16"

3 participants