Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Feb 27, 2025

Repurposed from #13943 to add a SupportsV0Only protocol to models that are not compatible with vLLM V1 so that we can programmatically check the compatibility such as in #13726.

Doing this protocol instead of SupportsV1 also helps more easily track these models to migrate them to V1 as well as touching fewer files, since most models are now supported by V1 vLLM.

One caveat is that PixtralHF is currently not compatible with V1 but there's no way for us to differentiate it from Llava since transformers uses LlavaForConditionalGeneration definition for both models.

Signed-off-by: Roger Wang <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify
Copy link

mergify bot commented Feb 27, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @ywang96.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 27, 2025
@mergify mergify bot removed the needs-rebase label Feb 27, 2025
Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
Signed-off-by: Roger Wang <[email protected]>
@ywang96
Copy link
Member Author

ywang96 commented Feb 27, 2025

@robertgshaw2-redhat I turned on CI - feel free to review this whenever you have time.

@robertgshaw2-redhat robertgshaw2-redhat merged commit 6c85da3 into vllm-project:main Feb 28, 2025
36 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants