Skip to content

[CI/Build] Add examples/ directory to be labelled by mergify #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[CI/Build] Add examples/ directory to be labelled by mergify #13944

merged 1 commit into from
Feb 27, 2025

Conversation

@b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Feb 27, 2025 •
edited by github-actions bot
Loading

The examples folder is published to the existing documentation, so this should be helpful in labelling PRs that touch this directory.

We could also narrow the scope with files~=^examples/.*\.(py|md|sh)$ if necessary...

@b8zhong
chore: add examples path to mergify
bd94295 
The examples folder is published to documentation, so this may be more consistent

Signed-off-by: Brayden Zhong <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 27, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 27, 2025
@b8zhong b8zhong changed the title chore: add examples path to mergify [CI/Build] Add examples/ directory to be labelled by mergify Feb 27, 2025
DarkLight1337
DarkLight1337 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 27, 2025 04:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
@b8zhong
Copy link
Contributor Author

b8zhong commented Feb 27, 2025

Many thanks!

@DarkLight1337 DarkLight1337 merged commit a7f3731 into vllm-project:main Feb 27, 2025
24 of 26 checks passed
@b8zhong b8zhong deleted the mergify-docs branch February 27, 2025 12:42
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@b8zhong @Akshat-Tripathi
[CI/Build] Add examples/ directory to be labelled by mergify (vllm-…
96faffa 
…project#13944)

Signed-off-by: Brayden Zhong <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@b8zhong @lulmer
[CI/Build] Add examples/ directory to be labelled by mergify (vllm-…
32271a9 
…project#13944)

Signed-off-by: Brayden Zhong <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@b8zhong @shreyankg
[CI/Build] Add examples/ directory to be labelled by mergify (vllm-…
aed204a 
…project#13944)

Signed-off-by: Brayden Zhong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@b8zhong @DarkLight1337