Skip to content

Conversation

@noamgat
Copy link
Contributor

@noamgat noamgat commented Feb 26, 2025

…rs library

I received reports in vLLM slack that this issue makes compiling vLLM with transformers 4.49 impossible. This fixes that problem.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 26, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update requirements-test.in

@noamgat
Copy link
Contributor Author

noamgat commented Feb 27, 2025 via email

@hmellor
Copy link
Member

hmellor commented Feb 27, 2025

Currently, requirements-test.txt (which is auto generated from requirements-test.in) is used to build the Docker image.

We should probably deduplicate this, but for now we must update both when changing requirements.

@hmellor
Copy link
Member

hmellor commented Feb 27, 2025

Actually LMFE is not one of the dependencies that's duplicated across these files. My mistake!

@hmellor hmellor enabled auto-merge (squash) February 27, 2025 08:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
@hmellor
Copy link
Member

hmellor commented Feb 27, 2025

Please can you make sure the DCO check passes.

@hmellor hmellor merged commit 1dd422b into vllm-project:main Feb 27, 2025
82 of 85 checks passed
@hmellor hmellor mentioned this pull request Mar 21, 2025
9 tasks
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants