-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
Update LMFE version to v0.10.11 to support new versions of transforme… #13930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update requirements-test.in
|
I thought that they pull in everything from common, and that if its in
common, it doesn't need to be in the others. Am I wrong?
…On Thu, Feb 27, 2025 at 12:30 AM Harry Mellor ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please also update requirements-test.in
—
Reply to this email directly, view it on GitHub
<#13930 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKFA2BEYFV4BLVISKGG4W32RY6ADAVCNFSM6AAAAABX6K4NUWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBWGA4TSNZUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Currently, We should probably deduplicate this, but for now we must update both when changing requirements. |
|
Actually LMFE is not one of the dependencies that's duplicated across these files. My mistake! |
|
Please can you make sure the DCO check passes. |
vllm-project#13930) Signed-off-by: Louis Ulmer <[email protected]>
…rs library
I received reports in vLLM slack that this issue makes compiling vLLM with transformers 4.49 impossible. This fixes that problem.