[ROCm][Quantization][Kernel] Use FP8 FNUZ when OCP flag is 0 or undefined #13851
Conversation
…ined Related to vllm-project#12593 In older versions of "hip/hip_fp8.h" header (before ROCm/clr@353f15a), both `HIP_FP8_TYPE_OCP` and `HIP_FP8_TYPE_FNUZ` are not defined, and the code implementation is in FNUZ, so it's better to write it in this way, such that we don't check if `HIP_FP8_TYPE_FNUZ` is there or not, and we just use FP8 FNUZ when `HIP_FP8_TYPE_OCP` is 0 or undefined. Signed-off-by: Hollow Man <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Good catch, this will bring back ROCm6.2 support |
github-actions
bot
added
the
ready
…ined (vllm-project#13851) Signed-off-by: Hollow Man <[email protected]>
…ined (vllm-project#13851) Signed-off-by: Hollow Man <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…ined (vllm-project#13851) Signed-off-by: Hollow Man <[email protected]>
5 participants
In older versions of "hip/hip_fp8.h" header (before ROCm/clr@353f15a), both
HIP_FP8_TYPE_OCPandHIP_FP8_TYPE_FNUZare not defined, and the code implementation is in FNUZ, so it's better to write it in this way, such that we don't check ifHIP_FP8_TYPE_FNUZis there or not, and we just use FP8 FNUZ whenHIP_FP8_TYPE_OCPis 0 or undefined.Related to #12593