Skip to content

Conversation

@SageMoore
Copy link
Contributor

@SageMoore SageMoore commented Feb 25, 2025

flash_attn_varlen_func in upstream flash-attn does not support the return_softmax_lse argument. This PR works around that issue by explicitly disabling chunked prefill and prefix caching on non-cuda platforms.

Here are the results from running llmeval with deepseek-ai/DeepSeek-Coder-V2-Lite-Instruct on an AMD system:

|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.7657|±  |0.0117|
|     |       |strict-match    |     5|exact_match|↑  |0.7453|±  |0.0120|

Here are the results from the same model on an H100 system without this PR

|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.7642|±  |0.0117|
|     |       |strict-match    |     5|exact_match|↑  |0.7468|±  |0.0120|

Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Sage Moore <[email protected]>
@mgoin mgoin added rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels Feb 25, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM

@DarkLight1337 DarkLight1337 merged commit 1d35662 into vllm-project:main Feb 26, 2025
59 checks passed
@SageMoore SageMoore deleted the sage/deepseek-rocm-fix branch March 3, 2025 15:18
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants