Skip to content

[Misc] Check that the model can be inspected upon registration #13743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

[Misc] Check that the model can be inspected upon registration #13743

merged 4 commits into from
Feb 25, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 24, 2025

Try to fix #11229 (comment)

@github-actions
Copy link

github-actions bot commented Feb 24, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Feb 24, 2025
Closed
1 task
youkaichao
youkaichao approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 25, 2025 06:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@simon-mo simon-mo merged commit 6724e79 into vllm-project:main Feb 25, 2025
33 of 40 checks passed
@DarkLight1337 DarkLight1337 deleted the try-import-on-register branch February 25, 2025 08:18
DarkLight1337 added a commit to DarkLight1337/vllm that referenced this pull request Feb 25, 2025
@DarkLight1337
[Bugfix] Revert inspection code in vllm-project#13743
c03395f 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 mentioned this pull request Feb 25, 2025
Merged
youkaichao pushed a commit that referenced this pull request Feb 25, 2025
@DarkLight1337
[Bugfix] Revert inspection code in #13743 (#13832)
f4133ce 
Signed-off-by: DarkLight1337 <[email protected]>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@DarkLight1337 @Akshat-Tripathi
[Misc] Check that the model can be inspected upon registration (vllm-…
4d5b2e3 
…project#13743)
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@DarkLight1337 @Akshat-Tripathi
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
d8265fd 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Misc] Check that the model can be inspected upon registration (vllm-…
51c632a 
…project#13743)

Signed-off-by: Louis Ulmer <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
fd90602 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Misc] Check that the model can be inspected upon registration (vllm-…
e7e0359 
…project#13743)
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
[Bugfix] Revert inspection code in vllm-project#13743 (vllm-project#1…
6ddc011 
…3832)

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Usage]: Cannot register custom model (Out-of-Tree Model Integration)

3 participants

@DarkLight1337 @youkaichao @simon-mo