Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Feb 21, 2025

Should be more efficient than TCP based

Should be more efficient than TCP based

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill requested a review from youkaichao February 21, 2025 23:58
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@youkaichao
Copy link
Member

the change looks good to me. do you have any performance numbers?

@njhill
Copy link
Member Author

njhill commented Feb 22, 2025

the change looks good to me. do you have any performance numbers?

@youkaichao no, I'm actually not sure how often this queue is used, it just seemed that it would make most sense to use the local transport for the local queue.

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 22, 2025
@youkaichao
Copy link
Member

for local communication, we usually use shared memory. this zmq socket is a backup plan when the message size is too large.

@njhill
Copy link
Member Author

njhill commented Feb 23, 2025

Understood, but it's still local-only right? so might as well use the local transport?

@njhill
Copy link
Member Author

njhill commented Feb 23, 2025

(remaining test failure was also failing on main I think)

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 23, 2025 10:54
@simon-mo simon-mo merged commit 5a2ba16 into vllm-project:main Feb 23, 2025
61 of 64 checks passed
@njhill njhill deleted the local-zmq-ipc branch February 23, 2025 15:31
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants