-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[Core][Distributed] Use IPC (domain socket) ZMQ socket for local comms #13688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should be more efficient than TCP based Signed-off-by: Nick Hill <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
the change looks good to me. do you have any performance numbers? |
@youkaichao no, I'm actually not sure how often this queue is used, it just seemed that it would make most sense to use the local transport for the local queue. |
|
for local communication, we usually use shared memory. this zmq socket is a backup plan when the message size is too large. |
|
Understood, but it's still local-only right? so might as well use the local transport? |
|
(remaining test failure was also failing on main I think) |
youkaichao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vllm-project#13688) Signed-off-by: Louis Ulmer <[email protected]>
Should be more efficient than TCP based