Skip to content

Conversation

@MengqingCao
Copy link
Contributor

This pr removes cuda hard code in models and layers, so that they could be easily used by the other devices.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement, LGTM

Signed-off-by: Mengqing Cao <[email protected]>
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
Signed-off-by: Mengqing Cao <[email protected]>
@MengqingCao
Copy link
Contributor Author

It seems the inference accuracy is breaked by some commit before this pr. I'm looking into it now.

@MengqingCao
Copy link
Contributor Author

It seems a little far to find which pr introduced the accuracy problem.
I have rebase the code to 9cdea30, but the acc problem still exists.

@simon-mo simon-mo merged commit 23eca9c into vllm-project:main Feb 24, 2025
46 of 48 checks passed
@MengqingCao MengqingCao deleted the hard_code branch February 25, 2025 08:43
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants