-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[model][refactor] remove cuda hard code in models and layers #13658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Mengqing Cao <[email protected]>
94fe00f to
949f6b8
Compare
jeejeelee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement, LGTM
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]>
|
It seems the inference accuracy is breaked by some commit before this pr. I'm looking into it now. |
|
It seems a little far to find which pr introduced the accuracy problem. |
…oject#13658) Signed-off-by: Louis Ulmer <[email protected]>
This pr removes cuda hard code in models and layers, so that they could be easily used by the other devices.