Skip to content

Conversation

@gongdao123
Copy link
Contributor

@gongdao123 gongdao123 commented Feb 21, 2025

fix native attention function call for navi cards

FIX #13648

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gongdao123 gongdao123 force-pushed the native_attention_fix_for_navi branch from dfb8bb7 to 7a01206 Compare February 21, 2025 06:17
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 21, 2025 06:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@DarkLight1337
Copy link
Member

cc @hongxiayang

@DarkLight1337
Copy link
Member

There seems to be a problem with the CI when building the Docker image

unauthorized: access token has insufficient scopes

@DarkLight1337
Copy link
Member

cc @Alexei-V-Ivanov-AMD @khluu

@hongxiayang
Copy link
Collaborator

cc @maleksan85 Can you help to check?

Copy link
Contributor

@maleksan85 maleksan85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alexei-V-Ivanov-AMD
Copy link
Collaborator

Alexei-V-Ivanov-AMD commented Feb 21, 2025

There seems to be a problem with the CI when building the Docker image

I'm going to try reproducing later this evening.

@DarkLight1337
Copy link
Member

Meanwhile let's merge this first.

@simon-mo simon-mo merged commit 68d630a into vllm-project:main Feb 22, 2025
26 of 34 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [ROCM] _sdpa_attention() takes from 8 to 9 positional arguments but 10 were given

6 participants