Skip to content

Conversation

@terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Feb 18, 2025

Currently None is printed out. We should only print it when the chat template is supplied.

INFO 02-18 01:35:41 executor_base.py:115] Maximum concurrency for 32768 tokens per request: 1.00x
INFO 02-18 01:35:43 llm_engine.py:431] init engine (profile, create kv cache, warmup model) took 1.15 seconds
INFO 02-18 01:35:43 api_server.py:756] Using supplied chat template:
INFO 02-18 01:35:43 api_server.py:756] None

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 18, 2025
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improvement

Signed-off-by: Yuan Tang <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@mgoin mgoin enabled auto-merge (squash) February 18, 2025 03:14
@simon-mo simon-mo merged commit a1074b3 into vllm-project:main Feb 18, 2025
54 of 58 checks passed
@terrytangyuan terrytangyuan deleted the fix-chat-tmpl-none branch February 18, 2025 09:45
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants