-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[V1][Metrics] Support vllm:cache_config_info
#13299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1][Metrics] Support vllm:cache_config_info
#13299
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
prometheus_client has support for Info metrics which are equivalent to
a Gauge whose value is permanently set to 1, but exposes interesting
key/value pair information via labels. This is used for information
about an instance that does not change - so it only needs to be
observed at startup - and allows comparing across instances in
Prometheus.
We use this concept for the vllm:cache_config_info metric:
```
vllm:cache_config_info{block_size="16",cache_dtype="auto",calculate_kv_scales="False",cpu_offload_gb="0",enable_prefix_caching="False",gpu_memory_utilization="0.9",...} 1.0
```
However, prometheus_client has never supported Info metrics in
multiprocessing mode - for unclear reasons. We simply use a Gauge
metric set to 1 and multiprocess_mode="mostrecent" instead.
Signed-off-by: Mark McLoughlin <[email protected]>
e703bac to
53e39cc
Compare
robertgshaw2-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one we should consider adding to the deprecation list.
Signed-off-by: Louis Ulmer <[email protected]>
Part of #10582
prometheus_client has support for Info metrics which are equivalent to a Gauge whose value is permanently set to 1, but exposes interesting key/value pair information via labels. This is used for information about an instance that does not change - so it only needs to be observed at startup - and allows comparing across instances in Prometheus.
We use this concept for the
vllm:cache_config_infometric:However, prometheus_client has never supported Info metrics in multiprocessing mode - for unclear reasons. We simply use a Gauge metric set to 1 and
multiprocess_mode="mostrecent"instead.