-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[LMM] Implement merged multimodal processor for whisper #13278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need @ywang96 to comment on the profiling changes.
|
After this PR, can you update the model development docs with some info on how to implement merged multi-modal processor for encoder-decoder models? |
Yes, I will add a doc using whisper and florence-2 as e2e example respectively after this PR and #13320 merged, because there is also a minor change on |
Signed-off-by: Isotr0py <[email protected]>
ywang96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Isotr0py Sorry for the late review - I left a comment regarding the change on creator_encoder_prompt. Please take a look!
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
|
Can you merge from main and fix the pre-commit issues? |
…#13278) Signed-off-by: Louis Ulmer <[email protected]>
TODO