Skip to content

[V1][Minor] Restore V1 compatibility with LLMEngine class #13090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[V1][Minor] Restore V1 compatibility with LLMEngine class #13090

merged 1 commit into from
Feb 28, 2025

Conversation

@Ryp
Copy link
Contributor

@Ryp Ryp commented Feb 11, 2025 •
edited by github-actions bot
Loading

The check was added to AsyncLLMEngine but not LLMEngine.

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Ryp Ryp force-pushed the fix-v1-compat branch 4 times, most recently from cd291ed to 0acfcaa Compare February 11, 2025 14:11
@Ryp
Copy link
Contributor Author

Ryp commented Feb 13, 2025

This is ready for review, thanks in advance!

comaniac
comaniac approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@mgoin mgoin enabled auto-merge (squash) February 19, 2025 18:26
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 22, 2025

V1 test keeps failing, PTAL.

auto-merge was automatically disabled February 25, 2025 11:29

Head branch was pushed to by a user without write access

@Ryp
[V1][Minor] Restore V1 compatibility with LLMEngine class
4a6f4bd 
The check was added to AsyncLLMEngine but not LLMEngine.

Signed-off-by: Thibault Schueller <[email protected]>

Signed-off-by: 'Thibault Schueller' <'[email protected]'>
@vllm-bot vllm-bot merged commit b3f7aac into vllm-project:main Feb 28, 2025
42 of 46 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@Ryp @Akshat-Tripathi
[V1][Minor] Restore V1 compatibility with LLMEngine class (vllm-proje…
181d4bf 
…ct#13090)
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Ryp @lulmer
[V1][Minor] Restore V1 compatibility with LLMEngine class (vllm-proje…
114ba88 
…ct#13090)

Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Ryp @shreyankg
[V1][Minor] Restore V1 compatibility with LLMEngine class (vllm-proje…
cbb57fa 
…ct#13090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@comaniac comaniac comaniac approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@njhill njhill Awaiting requested review from njhill

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Ryp @DarkLight1337 @mgoin @comaniac @robertgshaw2-redhat @vllm-bot