Skip to content

[BUGFIX] Skip tokenization support for throughput benchmark #12712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

[BUGFIX] Skip tokenization support for throughput benchmark #12712

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
576bc6a
adding support for skip tokenizer benchmarking
Feb 3, 2025
18c8ef6
acted up on comments in PR
Mar 4, 2025
6d2f700
merge with main
Mar 4, 2025
5e16d39
description change
Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/benchmark_throughput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import random
import time
from functools import cache
from typing import Dict, List, Optional, Tuple
from typing import Dict, List, Optional, Tuple, Union

import torch
import uvloop
Expand Down Expand Up @@ -171,7 +171,7 @@ def run_vllm(
llm = LLM(**dataclasses.asdict(engine_args))

# Add the requests to the engine.
prompts: List[TextPrompt | TokensPrompt] = []
prompts: List[Union[TextPrompt, TokensPrompt]] = []
sampling_params: List[SamplingParams] = []
for request in requests:
prompts.append(
Expand Down Expand Up @@ -232,7 +232,7 @@ async def run_vllm_async(
engine_args, disable_frontend_multiprocessing) as llm:

# Add the requests to the engine.
prompts: List[TextPrompt | TokensPrompt] = []
prompts: List[Union[TextPrompt, TokensPrompt]] = []
sampling_params: List[SamplingParams] = []
lora_requests: List[Optional[LoRARequest]] = []
for request in requests:
Expand Down
4 changes: 3 additions & 1 deletion vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser:
parser.add_argument(
'--skip-tokenizer-init',
action='store_true',
help='Skip initialization of tokenizer and detokenizer.')
help='Skip tokenizer\detokenizer use during model inference. '
'Use of tokenizer\detokenizer increases host overhead and might '
'end up of GPU underutilization')
parser.add_argument(
'--revision',
type=nullable_str,
Expand Down