Skip to content

[ROCm][Quantization][Kernel] Using HIP FP8 header #12593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 25, 2025
Merged

[ROCm][Quantization][Kernel] Using HIP FP8 header #12593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38c7e86
Using the official hip fp8 header supplied with ROCm instead of a cus…
gshtras Jan 30, 2025
d90136f
Relative path
gshtras Jan 30, 2025
d9f3bce
Format
gshtras Jan 30, 2025
f714e38
Improved cmake comments
gshtras Feb 11, 2025
35d20b7
Merge remote-tracking branch 'origin/main' into fp8_header_upstream
gshtras Feb 17, 2025
f29855b
Merge remote-tracking branch 'origin/main' into fp8_header_upstream
gshtras Feb 20, 2025
bd76cae
Merge remote-tracking branch 'origin/main' into fp8_header_upstream
gshtras Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,25 @@ include(FetchContent)
file(MAKE_DIRECTORY ${FETCHCONTENT_BASE_DIR}) # Ensure the directory exists
message(STATUS "FetchContent base directory: ${FETCHCONTENT_BASE_DIR}")

#
# Set rocm version dev int.
#
if(VLLM_GPU_LANG STREQUAL "HIP")
#
# Overriding the default -O set up by cmake, adding ggdb3 for the most verbose devug info
#
set(CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG "${CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG} -O0 -ggdb3")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -O0 -ggdb3")


#
# Certain HIP functions are marked as [[nodiscard]], yet vllm ignores the result which generates
# a lot of warnings that always mask real issues. Suppressing until this is properly addressed.
#
set(CMAKE_${VLLM_GPU_LANG}_FLAGS "${CMAKE_${VLLM_GPU_LANG}_FLAGS} -Wno-unused-result")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-result")
endif()

#
# Define other extension targets
#
Expand Down
137 changes: 0 additions & 137 deletions csrc/quantization/fp8/amd/hip_float8.h
View file
Open in desktop

This file was deleted.

Loading