Skip to content

Conversation

@tlrmchlsmth
Copy link
Member

@tlrmchlsmth tlrmchlsmth commented Jan 30, 2025

Integrates the block-quantized kernels introduced in #11868 for use in linear layers.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 30, 2025
@tlrmchlsmth tlrmchlsmth marked this pull request as ready for review January 31, 2025 21:15
@tlrmchlsmth tlrmchlsmth changed the title [Kernel][Quantization] Integrate block cutlass [Kernel][Quantization] Integrate block-quantized CUTLASS kernels for DeepSeekV3 Jan 31, 2025
@tlrmchlsmth tlrmchlsmth force-pushed the integrate_block_cutlass branch from bbf58e5 to f9e3256 Compare January 31, 2025 21:34
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 31, 2025
@mgoin
Copy link
Member

mgoin commented Jan 31, 2025

Confirmed accuracy with gsm8k eval

VLLM_MLA_DISABLE=1 lm_eval --model vllm --model_args pretrained=/data/nm/models/DeepSeek-R1,trust_remote_code=True,tensor_parallel_size=8,max_model_len=10000 --tasks gsm8k --num_fewshot 5 --batch_size auto
...
Processed prompts: 100%|██████████| 1319/1319 [05:03<00:00,  4.35it/s, est. speed input: 3791.39 toks/s, output: 446.01 toks/s]
Running generate_until requests: 100%|███████████| 1319/1319 [05:03<00:00,  4.34it/s]
vllm (pretrained=/data/nm/models/DeepSeek-R1,trust_remote_code=True,tensor_parallel_size=8,max_model_len=10000), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.9522|±  |0.0059|
|     |       |strict-match    |     5|exact_match|↑  |0.9522|±  |0.0059|

@simon-mo
Copy link
Collaborator

Confirmed on TP8PP2 setting
Before Run 1:
Throughput: 0.33 requests/s, 1632.43 total tokens/s, 326.49 output tokens/s

Before Run 2:
Throughput: 0.32 requests/s, 1587.24 total tokens/s, 317.45 output tokens/s

This PR
Throughput: 0.35 requests/s, 1735.48 total tokens/s, 347.10 output tokens/s

@simon-mo simon-mo merged commit eb5741a into vllm-project:main Jan 31, 2025
51 of 70 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Srikanth Srinivas <[email protected]>
sahelib25 pushed a commit to krai/vllm that referenced this pull request Feb 3, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
yessenzhar pushed a commit to deepinfra/vllm that referenced this pull request Feb 3, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
pathorn pushed a commit to deepinfra/vllm that referenced this pull request Feb 14, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
pathorn pushed a commit to deepinfra/vllm that referenced this pull request Feb 19, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
…DeepSeekV3 (vllm-project#12587)

Integrates the block-quantized kernels introduced in
vllm-project#11868 for use in linear
layers.

Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants