Skip to content

[do not merge] V1 scheduler interface #12544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[do not merge] V1 scheduler interface #12544

wants to merge 4 commits into from

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Jan 29, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@njhill njhill added the v1 label Feb 4, 2025
@mergify
Copy link

mergify bot commented Feb 4, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 4, 2025
@wangxiyuan
Copy link
Contributor

wangxiyuan commented Feb 26, 2025

@WoosukKwon Any plan to complete this PR? Thanks

@wangxiyuan wangxiyuan mentioned this pull request Feb 27, 2025
Closed
38 tasks
joerunde
joerunde reviewed Feb 28, 2025
View reviewed changes
vllm/v1/engine/core.py
from vllm.utils import get_exception_traceback, zmq_socket_ctx
from vllm.v1.core.kv_cache_utils import get_kv_cache_config
from vllm.v1.core.scheduler import Scheduler
from vllm.v1.core.scheduler.scheduler import Scheduler
Copy link
Collaborator

@joerunde joerunde Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intent here to also update the engine core to use a configurable type for the scheduler, now that we have an interface for it?

@GindaChen
Copy link
Contributor

GindaChen commented Feb 28, 2025

Hey @WoosukKwon - I would like to take a look and this PR and see if we can continue working on this.

This was referenced Mar 4, 2025
Closed
Merged
@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Mar 13, 2025

@GindaChen @joerunde @wangxiyuan Sorry for the delay. I created a new PR #14731.

@WoosukKwon WoosukKwon closed this Mar 13, 2025
@WoosukKwon WoosukKwon deleted the v1-scheduler-interface branch July 1, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat will be requested when the pull request is marked ready for review robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill will be requested when the pull request is marked ready for review njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 will be requested when the pull request is marked ready for review ywang96 is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat will be requested when the pull request is marked ready for review alexm-redhat is a code owner

@heheda12345 heheda12345 Awaiting requested review from heheda12345 heheda12345 will be requested when the pull request is marked ready for review heheda12345 is a code owner

@ApostaC ApostaC Awaiting requested review from ApostaC ApostaC will be requested when the pull request is marked ready for review ApostaC is a code owner

1 more reviewer

@joerunde joerunde joerunde left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WoosukKwon @wangxiyuan @GindaChen @joerunde @njhill