Skip to content

[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral #12303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2025
Merged

[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral #12303

merged 5 commits into from
Mar 24, 2025

Conversation

@zhenwei-intel
Copy link
Contributor

@zhenwei-intel zhenwei-intel commented Jan 22, 2025 •
edited by github-actions bot
Loading

Enable Dynamic MoE for Mixtral

Command for testing accuracy:
bash .buildkite/lm-eval-harness/run-lm-eval-gsm-hf-baseline.sh -m neuralmagic/Mixtral-8x7B-Instruct-v0.1 -b 32 -l 250 -f 5 -t 4

Accuracy results for bf16 precision:
image

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@zhenwei-intel zhenwei-intel force-pushed the gaudi/support_fusedmoe branch 2 times, most recently from cde00ea to eeac620 Compare January 22, 2025 08:50
@mgoin mgoin self-requested a review January 22, 2025 15:23
@zhenwei-intel zhenwei-intel force-pushed the gaudi/support_fusedmoe branch 2 times, most recently from 0461c56 to 7d0a9d9 Compare January 23, 2025 06:42
@zhenwei-intel zhenwei-intel marked this pull request as ready for review January 23, 2025 06:42
@zhenwei-intel zhenwei-intel force-pushed the gaudi/support_fusedmoe branch 2 times, most recently from ae8016b to 99096ae Compare February 5, 2025 08:02
@zhenwei-intel
Copy link
Contributor Author

zhenwei-intel commented Feb 8, 2025

@kzawora-intel @mgoin, Hi, could you help review this pr?

mgoin
mgoin reviewed Feb 11, 2025
View reviewed changes
@zhenwei-intel zhenwei-intel requested a review from mgoin February 12, 2025 05:12
@zhenwei-intel
Copy link
Contributor Author

zhenwei-intel commented Feb 17, 2025

Hi @mgoin, could you review the updated code again?

WoosukKwon
WoosukKwon reviewed Feb 19, 2025
View reviewed changes
@mergify
Copy link

mergify bot commented Feb 19, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhenwei-intel.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 19, 2025
@mergify mergify bot removed the needs-rebase label Feb 20, 2025
@zhenwei-intel
rebase main
00dcb05 
Signed-off-by: zhenwei <[email protected]>
@zhenwei-intel
Copy link
Contributor Author

zhenwei-intel commented Feb 26, 2025

Hi @mgoin @WoosukKwon , could you help review again?

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 6, 2025
@mergify
Copy link

mergify bot commented Mar 6, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @zhenwei-intel.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 6, 2025
@mergify mergify bot removed the needs-rebase label Mar 7, 2025
WoosukKwon
WoosukKwon approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay.

@WoosukKwon WoosukKwon merged commit 5eeadc2 into vllm-project:main Mar 24, 2025
36 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@zhenwei-intel @erictang000
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
d5d8c45 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@zhenwei-intel @wrmedford
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
863004a 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@zhenwei-intel @lulmer
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
e8fa54b 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@zhenwei-intel @lk-chen
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
6ec1b46 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@zhenwei-intel @shreyankg
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
7c1a26f 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@zhenwei-intel
[Hardware][Gaudi][Feature] Enable Dynamic MoE for Mixtral (vllm-proje…
f77b06a 
…ct#12303)

Signed-off-by: zhenwei <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhenwei-intel @mgoin @WoosukKwon @khluu