Skip to content

Conversation

@ApostaC
Copy link
Collaborator

@ApostaC ApostaC commented Dec 26, 2024

Note: This PR is part of the big CPU offloading PR #10874 -- this PR contains a benchmark script of "long document QA" use case, to test the effectiveness of CPU offloading

About the workload

The workload has N different long documents. It will shuffle the documents and query the serving engine multiple times, where each time it has N queries + each query has one of the documents as the prefix.

Example usage:

The following command runs the vLLM with 50GB CPU memory for offloading.
The workload samples 8 different prompts with a default input length of 20K tokens, then replicates each prompt 2 times.

    python benchmark_long_document_qa.py \
        --model meta-llama/Llama-2-7b-chat-hf \
        --enable-prefix-caching \
        --block-allocator CpuOffloadingBlockAllocator \
        --num-documents 8 \
        --repeat-count 2 \
        --cpu-memory-gb 50

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@KuntaiDu KuntaiDu added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 27, 2024
@comaniac comaniac self-assigned this Dec 28, 2024
@ApostaC ApostaC requested a review from comaniac December 31, 2024 20:42
@ApostaC
Copy link
Collaborator Author

ApostaC commented Dec 31, 2024

Hey @comaniac , thanks for all the comments. I've addressed them and the PR is ready for review again.

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks!

Signed-off-by: ApostaC <[email protected]>
@comaniac comaniac enabled auto-merge (squash) December 31, 2024 22:40
@comaniac comaniac merged commit 0c6f998 into vllm-project:main Jan 1, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants