Skip to content

[Bugfix] Enforce no chunked prefill for embedding models #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2024
Merged

[Bugfix] Enforce no chunked prefill for embedding models #10470

merged 4 commits into from
Nov 20, 2024

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 20, 2024

FIX #10444

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 20, 2024
@github-actions
Copy link

github-actions bot commented Nov 20, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 20, 2024
robertgshaw2-redhat
robertgshaw2-redhat reviewed Nov 20, 2024
View reviewed changes
@DarkLight1337
Update compatibility matrix
ba11c7a 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 force-pushed the embedding-no-chunked-prefill branch from 6eee5c4 to ba11c7a Compare November 20, 2024 03:30
@DarkLight1337
Rename header
b82b912 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Remove print statement
fb3a585 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 20, 2024 04:01
@DarkLight1337 DarkLight1337 merged commit b4be5a8 into vllm-project:main Nov 20, 2024
51 of 52 checks passed
@DarkLight1337 DarkLight1337 deleted the embedding-no-chunked-prefill branch November 20, 2024 06:35
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 25, 2024
Merged
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@DarkLight1337
[Bugfix] Enforce no chunked prefill for embedding models (vllm-projec…
8a5da49 
…t#10470)

Signed-off-by: DarkLight1337 <[email protected]>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 10, 2025
@DarkLight1337 @anko-intel
[Bugfix] Enforce no chunked prefill for embedding models (vllm-projec…
a1fa9f5 
…t#10470)

Signed-off-by: DarkLight1337 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: request reward model report 500 Internal Server Error

2 participants

@DarkLight1337 @robertgshaw2-redhat