Skip to content

Conversation

@reyoung
Copy link

@reyoung reyoung commented Nov 8, 2024

Fix flashinfer prefill.plan bug.

It is similar to PR #8173, but in #8173 , the prefill code is not modified.

cc @pavanimajety @yzh119 @comaniac

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@reyoung reyoung force-pushed the feature/fix_flash_infer_bug branch from ea73f6c to 09064d4 Compare November 8, 2024 03:47
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L366-368 are changed by format.sh when I run it locally.

@reyoung reyoung force-pushed the feature/fix_flash_infer_bug branch from 09064d4 to 697d9d1 Compare November 8, 2024 04:43
@reyoung reyoung force-pushed the feature/fix_flash_infer_bug branch from 697d9d1 to 6d28546 Compare November 8, 2024 04:56
@hmellor
Copy link
Member

hmellor commented Jan 17, 2025

Could you provide some more context about the bug?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Apr 18, 2025
@mergify
Copy link

mergify bot commented Apr 18, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @reyoung.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 18, 2025
@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Apr 19, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added stale Over 90 days of inactivity and removed unstale Recieved activity after being labelled stale labels Jul 19, 2025
@hmellor hmellor closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase stale Over 90 days of inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants