Skip to content

Conversation

@tjohnson31415
Copy link
Collaborator

Description

We are seeing test failures in CI from logprobs differences with the ibm-granite/granite-3.3-8b-instruct-FP8 model. This happens somewhat randomly... so this PR will convert these failures into xfail while still having the tests execute.

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@tjohnson31415 tjohnson31415 merged commit c6cc61f into main Nov 18, 2025
20 checks passed
@tjohnson31415 tjohnson31415 deleted the maybe-xfail branch November 18, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants