[s390x] Update s390x depencies #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikhil-Suryawanshi <[email protected]>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
joerunde
reviewed
Oct 1, 2025
pyproject.toml
Outdated
| # Skip packages only on s390x, expected to be pre-installed | ||
| "vllm ; platform_machine != 's390x'", | ||
| "ray; platform_machine != 's390x'", | ||
| "ray[default]; platform_machine != 's390x'", |
Collaborator
There was a problem hiding this comment.
I think this is causing all the ray[default] deps to be pulled in for x86 (see all the uv.lock additions) which is not what we want
Signed-off-by: Nikhil-Suryawanshi <[email protected]>
joerunde
reviewed
Oct 1, 2025
| ] | ||
|
|
||
| [[package]] | ||
| name = "cupy-cuda12x" |
Collaborator
There was a problem hiding this comment.
nice!
Not sure how this was pulled in anyway- good to see it removed. Maybe this was from ray[cgraph]?
joerunde
pushed a commit
that referenced
this pull request
Oct 14, 2025
# Description This PR follows [494](#494). Certain dependencies of vllm-spyre are not readily available on ppc64le arch. These will be skipped and handled manually. Signed-off-by: Daniel Schenker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Few pakcages are not available for s390x and usually built by source, skipping those packages from pyproject and executed
uv lock