Skip to content

[fp8] fix cb scheduler step tests #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wallashss merged 5 commits into from
Oct 1, 2025
Merged

[fp8] fix cb scheduler step tests #491

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
46552d0
min compiled batch size of 4 for cb tests
yannicks1 Sep 29, 2025
343a99a
compiling for the next power of two for batch size
yannicks1 Sep 29, 2025
bf2638a
fmt
yannicks1 Sep 29, 2025
6e3598a
fix fmt
yannicks1 Sep 29, 2025
e737961
add some comments
yannicks1 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/llm_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def get_engine(
model=model_name,
tokenizer=model_name,
max_model_len=max(max_model_len, 256),
max_num_seqs=max_num_seqs,
max_num_seqs=max(max_num_seqs, 4),
Copy link
Collaborator

@prashantgupta24 prashantgupta24 Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will leave the test name as-is, which might be confusing (since the test will still say BS 2)

num_gpu_blocks_override=None,
revision=revision,
)
Expand All @@ -203,6 +203,7 @@ def get_engine(
log_stats=False)

engine_core.scheduler.scheduler_config.max_model_len = max_model_len
engine_core.scheduler.scheduler_config.max_num_seqs = max_num_seqs

if available_blocks is not None:
worker = engine_core.model_executor.driver_worker.worker
Expand Down
Loading