Skip to content

⬆️ bump vllm lower bound to 0.10.1.1 #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prashantgupta24 merged 10 commits into from
Sep 22, 2025
Merged

⬆️ bump vllm lower bound to 0.10.1.1 #468

prashantgupta24 merged 10 commits into from
Sep 22, 2025

Conversation

@prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Sep 17, 2025 •
edited
Loading

Description

⬆️ bump vllm lower bound to 0.10.1.1 and remove a bunch of backward compatibility code.

Note: This is an intermediate PR for supporting the 0.10.2 since it makes it easy to remove backward compatibility code first before introducing breaking changes for the next release.

Related Issues

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24
🔥 remove model config back-comp
bd71f48 
Most of it was already removed by Max in his reranker PR

Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
🔥 remove tasks back-comp
2043127 
Some of it was already removed by Max in his reranker PR

Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
🔥 remove pooler args back-comp
486b6e8 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
🔥 remove multi-step back-comp
c461776 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
🔥 remove engine core request back-comp
041ebc0 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
🔥 remove init_builtin_logitsprocs back-comp
c01726e 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
⏪ revert local change
86fac43 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24
⏪ revert local change
9b8beb9 
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 changed the title ⬆️ bump vllm lower bound ⬆️ bump vllm lower bound to 0.10.1.1 Sep 17, 2025
@prashantgupta24 prashantgupta24 marked this pull request as ready for review September 17, 2025 22:47
prashantgupta24
prashantgupta24 commented Sep 17, 2025
View reviewed changes
vllm_spyre/v1/worker/spyre_worker.py
"""A worker class that executes the model on a group of Spyre cores.
"""

def get_supported_pooling_tasks(self):
Copy link
Collaborator Author

@prashantgupta24 prashantgupta24 Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this right? Not 100% sure, but no tests failed 🤷

Copy link
Collaborator

@yannicks1 yannicks1 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxdebayser ?

Copy link
Collaborator

@maxdebayser maxdebayser Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks like it can be removed. The worker has get_supported_tasks which calls the runner's get_supported_tasks

@prashantgupta24 prashantgupta24 mentioned this pull request Sep 18, 2025
Merged
maxdebayser
maxdebayser approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's nice to see all the compatibility code being removed.

@maxdebayser
Copy link
Collaborator

maxdebayser commented Sep 19, 2025

bot:test

1 similar comment
@prashantgupta24
Copy link
Collaborator Author

prashantgupta24 commented Sep 22, 2025

bot:test

@prashantgupta24 prashantgupta24 enabled auto-merge (squash) September 22, 2025 17:17
@github-actions github-actions bot added the ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage label Sep 22, 2025
@prashantgupta24 prashantgupta24 merged commit 12489a9 into main Sep 22, 2025
27 of 36 checks passed
@prashantgupta24 prashantgupta24 deleted the lower-bound-0.10.1.1 branch September 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxdebayser maxdebayser maxdebayser approved these changes

@joerunde joerunde Awaiting requested review from joerunde joerunde is a code owner

@ckadner ckadner Awaiting requested review from ckadner

@rafvasq rafvasq Awaiting requested review from rafvasq rafvasq is a code owner

@sducouedic sducouedic Awaiting requested review from sducouedic sducouedic is a code owner

@yannicks1 yannicks1 Awaiting requested review from yannicks1 yannicks1 is a code owner

@tdoublep tdoublep Awaiting requested review from tdoublep tdoublep is a code owner

@nikolaospapandreou nikolaospapandreou Awaiting requested review from nikolaospapandreou nikolaospapandreou is a code owner

Assignees

No one assigned

Labels

ready Runs the full CI test suite. Only add to PRs once ready to merge to limit public GHA usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prashantgupta24 @maxdebayser @yannicks1