[Fix] make images LoRA e2e less flaky#978
Merged
hsliuustc0106 merged 7 commits intovllm-project:mainfrom Jan 27, 2026
Merged
Conversation
Signed-off-by: dongbo910220 <[email protected]>
Contributor
Author
Collaborator
|
LGTM |
Collaborator
|
You should add "Diffusion Images API LoRA E2E" test ,refer to #975 |
Signed-off-by: dongbo910220 <[email protected]>
Contributor
Author
@david6666666 added and CI passed |
Signed-off-by: dongbo910220 <[email protected]>
Signed-off-by: dongbo910220 <[email protected]>
Signed-off-by: dongbo910220 <[email protected]>
Collaborator
|
Please fix CI |
Contributor
Author
@david6666666 The lora CI test passed and CI failure is about test_qwen3_omni.py which is not related with the PR, pls retry it. |
Collaborator
this is a know issue after #956 merged, but it does not occur every time |
Contributor
Author
Got it. Hope this time passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #977
CI.
switching back to no-LoRA.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)