Skip to content

Comments

[test] revert test flash attn file#972

Merged
david6666666 merged 2 commits intovllm-project:mainfrom
AndyZhou952:revert_fa_test
Jan 27, 2026
Merged

[test] revert test flash attn file#972
david6666666 merged 2 commits intovllm-project:mainfrom
AndyZhou952:revert_fa_test

Conversation

@AndyZhou952
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

This PR adds back test_flash_attn.py that was accidentally removed in #758. cc @ZJY0516 @SamitHuang


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: AndyZhou952 <[email protected]>
@SamitHuang SamitHuang self-requested a review January 27, 2026 03:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dec01ef3bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ZJY0516 ZJY0516 added the ready label to trigger buildkite CI label Jan 27, 2026
@ZJY0516 ZJY0516 enabled auto-merge (squash) January 27, 2026 07:03
@david6666666 david6666666 disabled auto-merge January 27, 2026 07:53
@david6666666 david6666666 enabled auto-merge (squash) January 27, 2026 07:53
@david6666666 david6666666 merged commit 8efd912 into vllm-project:main Jan 27, 2026
7 checks passed
nussejzz pushed a commit to nussejzz/vllm-omni that referenced this pull request Jan 27, 2026
@AndyZhou952 AndyZhou952 deleted the revert_fa_test branch January 29, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants