Skip to content

Comments

[Bugfix] raise error in diffusion engine and fix offload test#933

Merged
hsliuustc0106 merged 13 commits intovllm-project:mainfrom
ZJY0516:ci-fix
Jan 25, 2026
Merged

[Bugfix] raise error in diffusion engine and fix offload test#933
hsliuustc0106 merged 13 commits intovllm-project:mainfrom
ZJY0516:ci-fix

Conversation

@ZJY0516
Copy link
Collaborator

@ZJY0516 ZJY0516 commented Jan 23, 2026

Purpose

CPU offload tests have been consistently failing since PR #709 was merged. Even worse, CI does not catch this error

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: zjy0516 <[email protected]>
@ZJY0516 ZJY0516 added the ready label to trigger buildkite CI label Jan 23, 2026
@ZJY0516
Copy link
Collaborator Author

ZJY0516 commented Jan 23, 2026

Let's test cpu offload test robustness first

Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
@ZJY0516
Copy link
Collaborator Author

ZJY0516 commented Jan 23, 2026

don't merge. I need to test profiler as well

Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
@ZJY0516 ZJY0516 changed the title [Bugfix] close omni after generation complete [Bugfix] raise error in diffusion engine and fix offload test Jan 24, 2026
@ZJY0516 ZJY0516 requested a review from SamitHuang January 24, 2026 08:17
@hsliuustc0106
Copy link
Collaborator

resolve conflicts

Signed-off-by: zjy0516 <[email protected]>
Signed-off-by: zjy0516 <[email protected]>
Copy link
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsliuustc0106 hsliuustc0106 merged commit 578ed19 into vllm-project:main Jan 25, 2026
7 checks passed
majiayu000 pushed a commit to majiayu000/vllm-omni that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants