Skip to content

[bugfix] qwen3-tts check_model_inputs#924

Merged
david6666666 merged 1 commit intovllm-project:mainfrom
qibaoyuan:patch1
Jan 23, 2026
Merged

[bugfix] qwen3-tts check_model_inputs#924
david6666666 merged 1 commit intovllm-project:mainfrom
qibaoyuan:patch1

Conversation

@qibaoyuan
Copy link
Contributor

@qibaoyuan qibaoyuan commented Jan 23, 2026

ref: #923

[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/usr/lib/python3.12/importlib/__init__.py", line 90, in import_module
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     return _bootstrap._gcd_import(name[level:], package, level)
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap_external>", line 999, in exec_module
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/mnt/user/qibaoyuan/vllm-omni-qby/vllm_omni/model_executor/models/qwen3_tts/qwen3_tts.py", line 36, in <module>
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     from .modeling_qwen3_tts import Qwen3TTSForConditionalGeneration
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/mnt/user/qibaoyuan/vllm-omni-qby/vllm_omni/model_executor/models/qwen3_tts/modeling_qwen3_tts.py", line 54, in <module>
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     from .qwen3_tts_tokenizer import Qwen3TTSTokenizer
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/mnt/user/qibaoyuan/vllm-omni-qby/vllm_omni/model_executor/models/qwen3_tts/qwen3_tts_tokenizer.py", line 28, in <module>
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     from .tokenizer_12hz.modeling_qwen3_tts_tokenizer_v2 import (
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/mnt/user/qibaoyuan/vllm-omni-qby/vllm_omni/model_executor/models/qwen3_tts/tokenizer_12hz/modeling_qwen3_tts_tokenizer_v2.py", line 472, in <module>
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     class Qwen3TTSTokenizerV2DecoderTransformerModel(Qwen3TTSTokenizerV2DecoderPreTrainedModel):
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]   File "/mnt/user/qibaoyuan/vllm-omni-qby/vllm_omni/model_executor/models/qwen3_tts/tokenizer_12hz/modeling_qwen3_tts_tokenizer_v2.py", line 498, in Qwen3TTSTokenizerV2DecoderTransformerModel
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]     @check_model_inputs()
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768]      ^^^^^^^^^^^^^^^^^^^^
[Stage-0] ERROR 01-23 15:36:40 [registry.py:768] TypeError: check_model_inputs() missing 1 required positional argument: 'func'

Purpose

Fix a bug in the check_model_inputs annotation caused by an extra pair of parentheses.

Test Plan

python3 -u end2end.py --query-type Base --use-batch-sample

Test Result

Adding requests:   0%|                                                                                                                                                                                               | 0/2 [00:19<?, ?it/s]
Request ID: 0_5af8f90c-156e-418c-974f-7c77c77bbf45, Saved audio to output_audio/output_0_5af8f90c-156e-418c-974f-7c77c77bbf45.wav
Request ID: 1_20ec4969-a40b-4c03-b328-f0fc385f3a0e, Saved audio to output_audio/output_1_20ec4969-a40b-4c03-b328-f0fc385f3a0e.wav

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: 齐保元 <[email protected]>
Co-authored-by: shijin zhang <[email protected]>
Co-authored-by: ning ding <[email protected]>
@david6666666
Copy link
Collaborator

LTGM, thank you.

@david6666666 david6666666 added the ready label to trigger buildkite CI label Jan 23, 2026
@david6666666 david6666666 enabled auto-merge (squash) January 23, 2026 09:13
@david6666666 david6666666 merged commit 21ee1ff into vllm-project:main Jan 23, 2026
7 checks passed
gcanlin added a commit to gcanlin/vllm-omni that referenced this pull request Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: qwen3-tts TypeError: check_model_inputs() missing 1 required positional argument: 'func'

2 participants