Dev/debug qwen tts#903
Conversation
Signed-off-by: Taichang Zhou <tzhouam@connect.ust.hk>
Signed-off-by: Taichang Zhou <tzhouam@connect.ust.hk>
|
LGTM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 332f343e32
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if not local_files_only and not os.path.isdir(pretrained_model_name_or_path): | ||
| download_cache_dir = kwargs.get("cache_dir", cache_dir) | ||
| download_revision = kwargs.get("revision", revision) | ||
| download_weights_from_hf_specific( | ||
| pretrained_model_name_or_path, | ||
| cache_dir=download_cache_dir, | ||
| allow_patterns=["speech_tokenizer/*"], | ||
| revision=download_revision, |
There was a problem hiding this comment.
Pass auth token when pre-downloading speech_tokenizer
The new pre-download step calls download_weights_from_hf_specific without propagating auth (e.g., token/use_auth_token). For gated or private HF repos, snapshot_download will 401 and raise before the later cached_file(...) call can use the provided auth token. This is a regression for users who relied on passing use_auth_token (or token) to from_pretrained to access private Qwen3 TTS checkpoints. Consider threading the token through to download_weights_from_hf_specific (or skipping the pre-download when auth is required).
Useful? React with 👍 / 👎.
|
merge to main as well |
a9012a1
into
vllm-project:release/v0.14.0rc1
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR debug the qwen 3 TTS
Test Plan
tested on end2end.py
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)