Skip to content

[fix] Remove redundant parameter passing #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaohan123 merged 3 commits into from
Nov 27, 2025
Merged

[fix] Remove redundant parameter passing #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23a9b67
[fix] parameter bug fix
qibaoyuan Nov 26, 2025
68f7306
[fix] code format by ruff
qibaoyuan Nov 26, 2025
c44ef5f
[fix] code format by ruff
qibaoyuan Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions vllm_omni/entrypoints/omni_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ def init_stage_worker(
self,
model,
stage_payload,
self._in_q,
self._out_q,
self._log_file,
batch_timeout,
),
)
Expand Down Expand Up @@ -487,21 +484,15 @@ def _stage_worker_async_entry(
omni_stage: OmniStage,
model: str,
stage_payload: dict[str, Any],
in_q: mp.Queue,
out_q: mp.Queue,
log_file: Optional[str] = None,
batch_timeout: int = 10,
) -> None:
asyncio.run(_stage_worker_async(omni_stage, model, stage_payload, in_q, out_q, log_file, batch_timeout))
asyncio.run(_stage_worker_async(omni_stage, model, stage_payload, batch_timeout))


async def _stage_worker_async(
omni_stage: OmniStage,
model: str,
stage_payload: dict[str, Any],
in_q: mp.Queue,
out_q: mp.Queue,
log_file: Optional[str] = None,
batch_timeout: int = 10,
) -> None:
"""Stage worker entry: device setup, LLM init, batching, SHM IPC."""
Expand All @@ -523,6 +514,9 @@ async def _stage_worker_async(
runtime_cfg = stage_payload.get("runtime", {})
shm_threshold_bytes = int(stage_payload.get("shm_threshold_bytes", 65536))

log_file = omni_stage._log_file
in_q = omni_stage._in_q
out_q = omni_stage._out_q
# Per-stage file logger (optional)
try:
if log_file:
Expand Down