Skip to content

Comments

[Bugfix] Diffusion model fails to load when stage config is present#860

Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
fhfuih:fix-stage-config-loading
Jan 20, 2026
Merged

[Bugfix] Diffusion model fails to load when stage config is present#860
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
fhfuih:fix-stage-config-loading

Conversation

@fhfuih
Copy link
Contributor

@fhfuih fhfuih commented Jan 20, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Fix #859

Test Plan

No new tests need to be added. For Qwen Omni models (In PR #722 that this bug introduces), ensure that current tests pass. For pure diffusion models, the max_batch_size field is not well supported or well documented. Either (1) test will be added in other PR when this field is better supported, (2) if this field is to be deprecated, no need to add more tests

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@fhfuih fhfuih requested a review from hsliuustc0106 as a code owner January 20, 2026 03:16
Copilot AI review requested due to automatic review settings January 20, 2026 03:16
@tzhouam tzhouam added the ready label to trigger buildkite CI label Jan 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hsliuustc0106 hsliuustc0106 merged commit 430c60b into vllm-project:main Jan 20, 2026
12 of 13 checks passed
with1015 pushed a commit to with1015/vllm-omni that referenced this pull request Jan 20, 2026
@fhfuih fhfuih deleted the fix-stage-config-loading branch January 28, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Diffusion models cannot launch with a stage config

4 participants