[Bugfix] Fix generation artifacts of Qwen-Image-Edit-2511 and update pipeline DiT param parsing #776
Merged
ZJY0516 merged 9 commits intovllm-project:mainfrom Jan 15, 2026
Merged
Conversation
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ac473c1eb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
SamitHuang
changed the title
1 task
SamitHuang
changed the title
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
SamitHuang
changed the title
ZJY0516
approved these changes
Jan 14, 2026
Contributor
|
@SamitHuang self.img_norm1 = AdaLayerNorm(dim, elementwise_affine=False, eps=eps) img_modulated, img_gate1 = self.img_norm1(hidden_states, img_mod1, modulate_index) |
gcanlin
reviewed
Jan 14, 2026
Contributor
gcanlin
left a comment
gcanlin
left a comment
There was a problem hiding this comment.
Teacache should also change the corresponding parameter.
Signed-off-by: samithuang <[email protected]>
Collaborator
Author
@yuanheng-zhao Currently qwen-image-edit with tea-cache still haves slight artifacts. I tried to add module_index in tea_cache as well, but get the following errror. Can you PTAL? |
Collaborator
perhaps it's related to torch compile |
GG-li
pushed a commit
to GG-li/vllm-omni
that referenced
this pull request
Jan 15, 2026
…pipeline DiT param parsing (vllm-project#776) Signed-off-by: samithuang <[email protected]>
5 tasks
GG-li
pushed a commit
to GG-li/vllm-omni
that referenced
this pull request
Jan 15, 2026
…pipeline DiT param parsing (vllm-project#776) Signed-off-by: Samit <[email protected]>
Contributor
Hey @SamitHuang , may I get the command you tested and got the torch compile exception? I added |
erfgss
pushed a commit
to erfgss/vllm-omni
that referenced
this pull request
Jan 19, 2026
…pipeline DiT param parsing (vllm-project#776) Signed-off-by: samithuang <[email protected]> Signed-off-by: Chen Yang <[email protected]>
with1015
pushed a commit
to with1015/vllm-omni
that referenced
this pull request
Jan 20, 2026
…pipeline DiT param parsing (vllm-project#776) Signed-off-by: samithuang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Fixed #675
Test Plan
Test Result
Before:
After:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)