Skip to content

Comments

[BugFix] Qwen2.5-omni supress end token and won't stop#773

Merged
hsliuustc0106 merged 4 commits intovllm-project:mainfrom
yinpeiqi:fix-qwen25
Jan 15, 2026
Merged

[BugFix] Qwen2.5-omni supress end token and won't stop#773
hsliuustc0106 merged 4 commits intovllm-project:mainfrom
yinpeiqi:fix-qwen25

Conversation

@yinpeiqi
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

In the current implementation, bad_word_processor will set the logits to -1e9 when encounter supress tokens, to avoid the vocab size mismatch. We found that the end token also will be set to -1e9, thus the program won't stop until reach max length.

Test Plan

Run end2end.py

Test Result

Before:

0_8990c4c2-dede-49cf-95b1-5cb93ef0ad05.txt
output_0_8990c4c2-dede-49cf-95b1-5cb93ef0ad05.wav

After:

0_163825c2-5c08-4fd1-89f1-f4ac9668ea26.txt
output_0_163825c2-5c08-4fd1-89f1-f4ac9668ea26.wav


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@Bounty-hunter @hsliuustc0106

Signed-off-by: yinpeiqi <[email protected]>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd75674698

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@hsliuustc0106
Copy link
Collaborator

@yenuo26 how can we use tests to catch such error?

@david6666666 david6666666 added this to the v0.14.0rc1 milestone Jan 14, 2026
@tzhouam tzhouam added the ready label to trigger buildkite CI label Jan 15, 2026
@tzhouam tzhouam self-requested a review January 15, 2026 02:11
@yenuo26
Copy link
Contributor

yenuo26 commented Jan 15, 2026

@yenuo26 how can we use tests to catch such error?

we use whisper in test case to convert speech to text. If the audio contains long segments of silence, it may lead to a discrepancy between the recognized text and the inferred text, ultimately causing the test case to fail.
like this pr: #720

@hsliuustc0106 hsliuustc0106 merged commit 35f994e into vllm-project:main Jan 15, 2026
7 checks passed
erfgss pushed a commit to erfgss/vllm-omni that referenced this pull request Jan 19, 2026
with1015 pushed a commit to with1015/vllm-omni that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants