[BugFix] Qwen2.5-omni supress end token and won't stop#773
Merged
hsliuustc0106 merged 4 commits intovllm-project:mainfrom Jan 15, 2026
Merged
[BugFix] Qwen2.5-omni supress end token and won't stop#773hsliuustc0106 merged 4 commits intovllm-project:mainfrom
hsliuustc0106 merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: yinpeiqi <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd75674698
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vllm_omni/model_executor/models/qwen2_5_omni/qwen2_5_omni_talker.py
Outdated
Show resolved
Hide resolved
Signed-off-by: yinpeiqi <[email protected]>
Collaborator
|
@yenuo26 how can we use tests to catch such error? |
Contributor
hsliuustc0106
approved these changes
Jan 15, 2026
1 task
erfgss
pushed a commit
to erfgss/vllm-omni
that referenced
this pull request
Jan 19, 2026
) Signed-off-by: yinpeiqi <[email protected]> Signed-off-by: Chen Yang <[email protected]>
with1015
pushed a commit
to with1015/vllm-omni
that referenced
this pull request
Jan 20, 2026
) Signed-off-by: yinpeiqi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
In the current implementation,
bad_word_processorwill set the logits to -1e9 when encounter supress tokens, to avoid the vocab size mismatch. We found that the end token also will be set to -1e9, thus the program won't stop until reach max length.Test Plan
Run end2end.py
Test Result
Before:
0_8990c4c2-dede-49cf-95b1-5cb93ef0ad05.txt
output_0_8990c4c2-dede-49cf-95b1-5cb93ef0ad05.wav
After:
0_163825c2-5c08-4fd1-89f1-f4ac9668ea26.txt
output_0_163825c2-5c08-4fd1-89f1-f4ac9668ea26.wav
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)
@Bounty-hunter @hsliuustc0106