[Feat] add vllm-omni version collection#740
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c92369f9e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| vllm_version=vllm_version, | ||
| vllm_omni_version=vllm_omni_version, |
There was a problem hiding this comment.
Add vllm_omni_version field to SystemEnv
The SystemEnv namedtuple is still defined without a vllm_omni_version field, but get_env_info() now passes vllm_omni_version= into the constructor. This raises TypeError: __new__() got an unexpected keyword argument 'vllm_omni_version' whenever collect_env.py runs, so the env collection fails entirely. You need to add the field to the SystemEnv definition (near the top of this file) to keep the constructor signature in sync.
Useful? React with 👍 / 👎.
7c92369 to
d0b3d56
Compare
Add vllm_omni_version field to SystemEnv to collect vLLM-Omni package version with git commit SHA. - Support setuptools-scm versioned packages (git sha from version tuple) - Fall back to git rev-parse for editable installs Signed-off-by: Sihyeon Jang <[email protected]>
d0b3d56 to
508af5f
Compare
ZJY0516
left a comment
There was a problem hiding this comment.
Thanks for contribution
|
Could we configure the build process to automatically embed the Git SHA into the package version during installation? |
congw729
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
Signed-off-by: Sihyeon Jang <[email protected]>
Signed-off-by: Sihyeon Jang <[email protected]> Signed-off-by: Chen Yang <[email protected]>
Signed-off-by: Sihyeon Jang <[email protected]>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Add vllm_omni_version field to collect_env.py for collecting vLLM-Omni package version with git commit SHA.
This helps users report their exact vLLM-Omni version when filing issues, especially since most users install via editable mode (uv pip install -e .) rather than released packages.
Changes:
Future improvement suggestion:
Consider adopting setuptools-scm (like vLLM does) to automatically embed git SHA into version at install time. This would:
Test Plan
python collect_env.py | grep -A5 "vLLM Info"
Test Result
============================== vLLM Info ============================== . . vLLM-Omni Version : 0.12.0rc1 (git sha: dde96c2) . .Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)