Skip to content

Comments

[Feat] add vllm-omni version collection#740

Merged
david6666666 merged 1 commit intovllm-project:mainfrom
sihyeonn:feat/sh-collect_env
Jan 13, 2026
Merged

[Feat] add vllm-omni version collection#740
david6666666 merged 1 commit intovllm-project:mainfrom
sihyeonn:feat/sh-collect_env

Conversation

@sihyeonn
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Add vllm_omni_version field to collect_env.py for collecting vLLM-Omni package version with git commit SHA.

This helps users report their exact vLLM-Omni version when filing issues, especially since most users install via editable mode (uv pip install -e .) rather than released packages.

Changes:

  • Add vllm_omni_version field to SystemEnv namedtuple
  • Add get_vllm_omni_version() function that:
    • Supports setuptools-scm versioned packages (parses git sha from version tuple)
    • Falls back to git rev-parse --short HEAD for editable installs
  • Display vLLM-Omni version in output under "vLLM Info" section

Future improvement suggestion:

Consider adopting setuptools-scm (like vLLM does) to automatically embed git SHA into version at install time. This would:

  • Capture the exact commit at pip install time (not current HEAD)
  • Work for both editable and regular installs
  • Generate versions like 0.12.0rc1.dev5+gdde96c2

Test Plan

python collect_env.py | grep -A5 "vLLM Info"

Test Result

==============================
         vLLM Info
==============================
.
.
vLLM-Omni Version            : 0.12.0rc1 (git sha: dde96c2)
.
.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c92369f9e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 585 to +586
vllm_version=vllm_version,
vllm_omni_version=vllm_omni_version,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add vllm_omni_version field to SystemEnv

The SystemEnv namedtuple is still defined without a vllm_omni_version field, but get_env_info() now passes vllm_omni_version= into the constructor. This raises TypeError: __new__() got an unexpected keyword argument 'vllm_omni_version' whenever collect_env.py runs, so the env collection fails entirely. You need to add the field to the SystemEnv definition (near the top of this file) to keep the constructor signature in sync.

Useful? React with 👍 / 👎.

@sihyeonn sihyeonn changed the title feat(collect_env): add vllm-omni version collection [FEAT] add vllm-omni version collection Jan 12, 2026
@sihyeonn sihyeonn force-pushed the feat/sh-collect_env branch from 7c92369 to d0b3d56 Compare January 12, 2026 00:52
Add vllm_omni_version field to SystemEnv to collect vLLM-Omni package version with git commit SHA.

- Support setuptools-scm versioned packages (git sha from version tuple)
- Fall back to git rev-parse for editable installs

Signed-off-by: Sihyeon Jang <[email protected]>
@sihyeonn sihyeonn force-pushed the feat/sh-collect_env branch from d0b3d56 to 508af5f Compare January 12, 2026 00:53
@sihyeonn sihyeonn changed the title [FEAT] add vllm-omni version collection [Feat] add vllm-omni version collection Jan 12, 2026
Copy link
Collaborator

@ZJY0516 ZJY0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution

@ZJY0516 ZJY0516 added the ready label to trigger buildkite CI label Jan 12, 2026
@ZJY0516
Copy link
Collaborator

ZJY0516 commented Jan 12, 2026

Could we configure the build process to automatically embed the Git SHA into the package version during installation?
@congw729

@sihyeonn
Copy link
Contributor Author

@ZJY0516 Thanks, also I opened #741

Copy link
Contributor

@congw729 congw729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@david6666666 david6666666 merged commit f761119 into vllm-project:main Jan 13, 2026
7 checks passed
sniper35 pushed a commit to sniper35/vllm-omni that referenced this pull request Jan 14, 2026
erfgss pushed a commit to erfgss/vllm-omni that referenced this pull request Jan 19, 2026
with1015 pushed a commit to with1015/vllm-omni that referenced this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants