[BugFix] Fix assuming all stage model have talker#730
Merged
hsliuustc0106 merged 2 commits intovllm-project:mainfrom Jan 10, 2026
Merged
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Collaborator
Contributor
|
That’s the code for support cuda graph in talker stage. We can merge this change for now. The code will be refactored later |
hsliuustc0106
approved these changes
Jan 10, 2026
Contributor
In this PR: #715, I have proposed the same solution, but the reviewer asked for simpler code. Could we refer to this and try to come up with a better solution? |
Collaborator
yes |
5 tasks
sniper35
pushed a commit
to sniper35/vllm-omni
that referenced
this pull request
Jan 11, 2026
Signed-off-by: princepride <wangzhipeng628@gmail.com> Signed-off-by: Dong Wang <dongw2019@gmail.com>
with1015
pushed a commit
to with1015/vllm-omni
that referenced
this pull request
Jan 20, 2026
Signed-off-by: princepride <wangzhipeng628@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related PR: #726
The original code blindly accessed
self.model.talker, assuming all stage models follow the Qwen2.5-Omni interface (wheretalkeris explicitly set toNoneif unused). This PR changes the access to usegetattr(self.model, "talker", None)to safely handle models lacking this attribute.